renames diffsync.DiffSync to diffsync.Adapter#242
Merged
Conversation
Kircheneer
force-pushed
the
lk-rename-diffsync-class
branch
from
August 24, 2023 22:31
4037c74 to
bf3a8dd
Compare
Kircheneer
force-pushed
the
lk-rename-diffsync-class
branch
2 times, most recently
from
August 24, 2023 23:17
27f68ed to
adab897
Compare
Kircheneer
force-pushed
the
lk-rename-diffsync-class
branch
from
August 24, 2023 23:24
adab897 to
3ed568d
Compare
chadell
reviewed
Aug 25, 2023
| fail-fast: true | ||
| matrix: | ||
| python-version: ["3.7", "3.8", "3.9", "3.10"] | ||
| poetry-version: ["1.5.1"] |
Contributor
There was a problem hiding this comment.
do you expect to parametrize test by poetry? why not pin it?
Contributor
Author
There was a problem hiding this comment.
This is the act of pinning it, without this its latest
chadell
reviewed
Aug 25, 2023
chadell
approved these changes
Aug 25, 2023
chadell
left a comment
chadell
left a comment
Contributor
There was a problem hiding this comment.
LGTM, my only question is on the test
Contributor
Author
|
Sorry @chadell, I was still experimenting with CI breakage, I will set to draft for now |
Kircheneer
marked this pull request as draft
August 25, 2023 14:18
Kircheneer
force-pushed
the
lk-rename-diffsync-class
branch
from
August 31, 2023 18:43
0cb4e91 to
b23d186
Compare
Kircheneer
marked this pull request as ready for review
August 31, 2023 18:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #233